Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: initialization of genJetMatch token in appropriate place [14_0_X] #45816

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Bug fix: initialization of genJetMatch token in appropriate place [14_0_X] #45816

merged 1 commit into from
Aug 31, 2024

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Aug 27, 2024

PR description:

As title says: this PR moves initialization of the genJetMatchToken to a correct place which fixes a bug.
This bug have not manifested until now as gen-matching is not used in central workflows.

PR validation:

Validated in a custom workflow with and without enabling gen-matching.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45802.

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Aug 27, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024 •
edited
Loading

A new Pull Request was created by @mbluj for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024 •
edited
Loading

cms-bot internal usage

@hqucms
Copy link
Contributor

hqucms commented Aug 27, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Aug 27, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-956aca/41164/summary.html
COMMIT: b8e0b48
CMSSW: CMSSW_14_0_X_2024-08-27-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45816/41164/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 51 log files, 31 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.83 3.87 -1.2% 2.228 2.245
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.44 3.49 -1.6% 2.263 2.683
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.56 3.62 -1.8% 2.265 2.666
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.62 6.74 -1.8% 2.096 2.378
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.61 3.66 -1.4% 2.139 2.557
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.20 5.31 -2.1% 2.169 2.469
2500.1 2.354 2.354 0.000 ( +0.0% ) 4.95 5.05 -2.0% 2.061 2.084
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.59 5.76 -3.1% 1.956 1.997
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.09 4.15 -1.5% 1.974 2.298
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.61 3.69 -2.3% 2.074 2.383
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.06 11.45 -3.5% 1.985 1.981
2500.301 2.833 2.833 0.000 ( +0.0% ) 9.92 9.67 +2.6% 1.967 1.965
2500.31 1.348 1.348 0.000 ( +0.0% ) 18.19 18.53 -1.9% 2.385 2.393
2500.311 1.757 1.757 0.000 ( +0.0% ) 13.98 14.25 -1.9% 2.463 2.467
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.32 1.42 -6.9% 1.696 1.698
2500.313 1.568 1.568 0.000 ( +0.0% ) 8.87 7.25 +22.3% 1.046 1.049
2500.314 1.236 1.236 0.000 ( +0.0% ) 13.42 13.88 -3.3% 1.888 2.289
2500.315 1.874 1.874 0.000 ( +0.0% ) 13.86 14.30 -3.1% 2.086 2.367
2500.316 3.342 3.342 0.000 ( +0.0% ) 1.95 2.00 -2.6% 1.934 2.316
2500.317 1.811 1.811 0.000 ( +0.0% ) 14.10 14.52 -2.9% 2.370 2.374
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.43 5.62 -3.5% 2.381 2.390
2500.319 3.364 3.364 0.000 ( +0.0% ) 1.74 1.81 -3.8% 2.033 2.327
2500.4 2.374 2.374 0.000 ( +0.0% ) 10.94 11.27 -2.9% 1.910 1.938
2500.401 1.885 1.885 0.000 ( +0.0% ) 9.82 10.13 -3.1% 1.634 1.860
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.88 10.03 -1.5% 1.916 1.918
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.38 1.43 -3.3% 1.967 1.968
2500.404 2.860 2.860 0.000 ( +0.0% ) 9.80 10.14 -3.4% 1.650 1.917
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.37 3.48 -3.0% 1.793 1.936
2500.406 5.491 5.491 0.000 ( +0.0% ) 1.27 1.31 -3.2% 1.994 1.994
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.08 15.64 -3.6% 1.668 1.606
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.43 9.69 -2.7% 1.612 1.586

@jfernan2
Copy link
Contributor

+1

@hqucms
Copy link
Contributor

hqucms commented Aug 27, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

backport of #45802

@mandrenguyen
Copy link
Contributor

type jetmet

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a456bd7 into cms-sw:CMSSW_14_0_X Aug 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed jetmet orp-approved reconstruction-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mbluj @cmsbuild @hqucms @jfernan2 @mandrenguyen